[
https://issues.apache.org/jira/browse/HDFS-13333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432227#comment-16432227
]
Elek, Marton commented on HDFS-13333:
-------------------------------------
Thank you very much [~GeLiXin] to addressing this issue, I think it's a good
step forward to improve the usability with more meaningful errors.
Just one comment: You added a new checked exception(IOException) to the
signature of ServicePlugin.stop(). This is a non-compatible change, every
existing ServicePlugin should be modified. Also it limits the places where we
can use the datanode service plugin (can we use it after this change from
hadoop 2.7?).
Is there any other solution without changing ServicePlugin? For me, an
unchecked RuntimeException is also acceptable (but it's a matter of taste.
Others prefer checked exceptions).
> Ozone: Introduce a new SCM Exception which will be thrown when mandatory
> property is missing
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-13333
> URL: https://issues.apache.org/jira/browse/HDFS-13333
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: LiXin Ge
> Priority: Major
> Labels: newbie
> Attachments: HDFS-13333-HDFS-7240.001.patch,
> HDFS-13333-HDFS-7240.002.patch, HDFS-13333.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory
> property. This was proposed by [~xyao] in [this comment|
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
