[ 
https://issues.apache.org/jira/browse/HDFS-13333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432424#comment-16432424
 ] 

genericqa commented on HDFS-13333:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 
31s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
49s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
12s{color} | {color:green} HDFS-7240 passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
24s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
25s{color} | {color:red} common in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 57s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
1s{color} | {color:red} hadoop-hdds/common in HDFS-7240 has 2 extant Findbugs 
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
21s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
21s{color} | {color:red} common in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
22s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
21s{color} | {color:red} common in HDFS-7240 failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
12s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
10s{color} | {color:red} common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 27m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
23s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
23s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 24s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
20s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
24s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
22s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
23s{color} | {color:red} common in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m 33s{color} 
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
15s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 22s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 23s{color} 
| {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
39s{color} | {color:red} The patch generated 47 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m 59s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.conf.TestCommonConfigurationFields |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:b78c94f |
| JIRA Issue | HDFS-13333 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918379/HDFS-13333-HDFS-7240.002.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 0e45825560f3 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19 
12:52:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 8475d6b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-mvnsite-hadoop-ozone_common.txt
 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-findbugs-hadoop-ozone_common.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-javadoc-hadoop-hdds_container-service.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/branch-javadoc-hadoop-ozone_common.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-mvninstall-hadoop-hdds_container-service.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-mvninstall-hadoop-ozone_common.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-mvnsite-hadoop-hdds_container-service.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-mvnsite-hadoop-ozone_common.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/whitespace-eol.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-findbugs-hadoop-hdds_container-service.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-findbugs-hadoop-ozone_common.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-javadoc-hadoop-hdds_container-service.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-javadoc-hadoop-ozone_common.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-unit-hadoop-hdds_container-service.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-unit-hadoop-ozone_common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 1367 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdds/common 
hadoop-hdds/container-service hadoop-ozone/common U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23861/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozone: Introduce a new SCM Exception which will be thrown when mandatory 
> property is missing 
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13333
>                 URL: https://issues.apache.org/jira/browse/HDFS-13333
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: LiXin Ge
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-13333-HDFS-7240.001.patch, 
> HDFS-13333-HDFS-7240.002.patch, HDFS-13333.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory 
> property. This was proposed by [~xyao] in  [this comment| 
> https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to