[
https://issues.apache.org/jira/browse/HDFS-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434947#comment-16434947
]
Bharat Viswanadham commented on HDFS-13413:
-------------------------------------------
Hi [~shashikant] Thanks for reporting and working on this.
Patch LGTM.
One minor NIT:
RegistereEndPointTask.java: Line 102-109
In 2 of the preconditions, it is mentioned as datanode Id, and in one it is
mentioned as datanode ID.
Can, we mention in all the places as datanode ID to be consistent.
> ClusterId and DatanodeUuid should be marked mandatory fileds in
> SCMRegisteredCmdResponseProto
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-13413
> URL: https://issues.apache.org/jira/browse/HDFS-13413
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Minor
> Fix For: HDFS-7240
>
> Attachments: HDFS-13413-HDFS-7240.000.patch
>
>
> ClusterId as well as the DatanodeUuid are optional fields in
> {{SCMRegisteredCmdResponseProto}}
> currently. We have to make both clusterId and DatanodeUuid as required field
> and handle it properly. As of now, we don't do anything with the response of
> datanode registration. We should validate the clusterId and also the
> datanodeUuid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
