[ 
https://issues.apache.org/jira/browse/HDFS-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435363#comment-16435363
 ] 

genericqa commented on HDFS-13413:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m 
49s{color} | {color:green} HDFS-7240 passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
13s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} HDFS-7240 passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
13s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 14s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
13s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
13s{color} | {color:red} container-service in HDFS-7240 failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
10s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
10s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 10s{color} | 
{color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 10s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
10s{color} | {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 21s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
12s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
12s{color} | {color:red} container-service in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 12s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
25s{color} | {color:red} The patch generated 5 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:b78c94f |
| JIRA Issue | HDFS-13413 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918723/HDFS-13413-HDFS-7240.002.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  cc  |
| uname | Linux 347432e2d606 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 40398d3 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| compile | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/branch-compile-hadoop-hdds_container-service.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/branch-javadoc-hadoop-hdds_container-service.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-mvninstall-hadoop-hdds_container-service.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-compile-hadoop-hdds_container-service.txt
 |
| cc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-compile-hadoop-hdds_container-service.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-compile-hadoop-hdds_container-service.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-mvnsite-hadoop-hdds_container-service.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-findbugs-hadoop-hdds_container-service.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-javadoc-hadoop-hdds_container-service.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-unit-hadoop-hdds_container-service.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 289 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/container-service U: hadoop-hdds/container-service |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23903/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> ClusterId and DatanodeUuid should be marked mandatory fileds in 
> SCMRegisteredCmdResponseProto
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13413
>                 URL: https://issues.apache.org/jira/browse/HDFS-13413
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Minor
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-13413-HDFS-7240.000.patch, 
> HDFS-13413-HDFS-7240.001.patch, HDFS-13413-HDFS-7240.002.patch
>
>
> ClusterId as well as the DatanodeUuid are optional fields in 
> {{SCMRegisteredCmdResponseProto}}
> currently. We have to make both clusterId and DatanodeUuid as required field 
> and handle it properly. As of now, we don't do anything with the response of 
> datanode registration. We should validate the clusterId and also the 
> datanodeUuid



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to