[ https://issues.apache.org/jira/browse/HDFS-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439638#comment-16439638 ]
genericqa commented on HDFS-13431: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 33s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} HDFS-7240 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 52s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m 28s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 39s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 51s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 37s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 53s{color} | {color:red} hadoop-hdds/common in HDFS-7240 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 39s{color} | {color:red} hadoop-ozone/ozone-manager in HDFS-7240 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 39s{color} | {color:green} HDFS-7240 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} integration-test in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 25m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 25m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 8s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-ozone/integration-test {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 39s{color} | {color:red} hadoop-ozone/ozone-manager generated 19 new + 1 unchanged - 0 fixed = 20 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 5s{color} | {color:green} common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s{color} | {color:green} client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 22s{color} | {color:red} integration-test in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s{color} | {color:green} ozone-manager in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 52s{color} | {color:green} hadoop-ozone in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 29s{color} | {color:red} The patch generated 1425 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}150m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-ozone/ozone-manager | | | Unread field:CreateBucketHandler.java:[line 78] | | | Unread field:DeleteBucketHandler.java:[line 76] | | | Unread field:InfoBucketHandler.java:[line 79] | | | Unread field:ListBucketHandler.java:[line 79] | | | Format-string method java.io.PrintStream.printf(String, Object[]) called with format string "Found :with format string "Found : %n buckets for volume : %s " wants 1 arguments but is given 2 in org.apache.hadoop.ozone.web.ozShell.bucket.ListBucketHandler.execute(CommandLine) At ListBucketHandler.java:[line 111] | | | Unread field:UpdateBucketHandler.java:[line 73] | | | Unread field:DeleteKeyHandler.java:[line 62] | | | Unread field:GetKeyHandler.java:[line 77] | | | Unread field:InfoKeyHandler.java:[line 63] | | | Unread field:ListKeyHandler.java:[line 102] | | | Format-string method java.io.PrintStream.printf(String, Object[]) called with format string "Found :with format string "Found : %n keys for bucket %s in volume : %s " wants 2 arguments but is given 3 in org.apache.hadoop.ozone.web.ozShell.keys.ListKeyHandler.execute(CommandLine) At ListKeyHandler.java:[line 119] | | | Unread field:PutKeyHandler.java:[line 78] | | | Unread field:DeleteVolumeHandler.java:[line 71] | | | Unread field:InfoVolumeHandler.java:[line 68] | | | Unread field:InfoVolumeHandler.java:[line 75] | | | Dead store to ozoneURI in org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine) At ListVolumeHandler.java:org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine) At ListVolumeHandler.java:[line 81] | | | Unread field:ListVolumeHandler.java:[line 84] | | | Format-string method java.io.PrintStream.printf(String, Object[]) called with format string "Found :with format string "Found : %n volumes for user : %s " wants 1 arguments but is given 2 in org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine) At ListVolumeHandler.java:[line 110] | | | Unread field:UpdateVolumeHandler.java:[line 69] | | Failed junit tests | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.ozone.container.common.impl.TestContainerPersistence | | | hadoop.ozone.web.client.TestKeys | | | hadoop.ozone.container.common.TestBlockDeletingService | | | hadoop.ozone.scm.TestAllocateContainer | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.scm.TestSCMCli | | | hadoop.ozone.scm.TestContainerSQLCli | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rest.TestOzoneRestClient | | | hadoop.ozone.ksm.TestKeySpaceManagerRestInterface | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.ksm.TestKeySpaceManager | | | hadoop.ozone.TestOzoneConfigurationFields | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.scm.TestXceiverClientManager | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:b78c94f | | JIRA Issue | HDFS-13431 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12919220/HDFS-13431-HDFS-7240.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux fb5fb80a4669 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / fd84dea | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager-warnings.html | | mvninstall | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/new-findbugs-hadoop-ozone_ozone-manager.html | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 2111 (vs. ulimit of 10000) | | modules | C: hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-tools/hadoop-ozone U: . | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23950/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: Ozone Shell should use RestClient and RpcClient > ------------------------------------------------------ > > Key: HDFS-13431 > URL: https://issues.apache.org/jira/browse/HDFS-13431 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Attachments: HDFS-13431-HDFS-7240.001.patch, > HDFS-13431-HDFS-7240.002.patch > > > Currently Ozone Shell uses OzoneRestClient. We should use both RestClient and > RpcClient instead of OzoneRestClient. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org