[
https://issues.apache.org/jira/browse/HDFS-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457617#comment-16457617
]
Nanda kumar commented on HDFS-13431:
------------------------------------
Thanks [~ljain] for working on this. Please find my review comments below.
CreateVolumeHandler.java
Line 85 - 87: {{quota}} is an optional field, if it's not passed from the
command-line we should not set it in {{volumeArgs}} (line 94).
GetKeyHandler.java
Line 42 & 43: Length greater than 80 characters
Line 117: If {{dataFilePath}} is {{null}} we have to print some error message
or throw an exception.
Handler.java
Line 28: Unused import
Line 90 & 91: We don't need to have {{scheme.equals("")}} and
{{scheme.isEmpty()}}, one should be enough as both of them does the same
condition check.
KeySpaceManager.java
Line 828 - 830: This change is not required. We can get KSM's hostname through
{{getServiceList}} call.
OzoneClientFactory.java
Line 295 - 300: Why do we need this change?
OzoneVolume.java
Line 242: The method argument can be named as {{startBucket}} instead of
{{prevBucket}}, and in the javadoc it can be explicitly mentioned that the
{{startBucket}} will be excluded in the result iterator.
OzoneBucket.java
Line 310: For {{prevKey}}, we can do the same thing that is suggested for
{{prevBucket}} in {{OzoneVolume}}.
TestOzoneShell.java
Line 166 - 175: Use {{KeySpaceManager#getServiceList}} for getting hostname and
related ports.
Can we move the methods {{OzoneVolume#asVolumeInfo}},
{{OzoneBucket#asBucketInfo}} and {{OzoneKey#asKeyInfo}} from the respective
classes into a common utility class. Since this functionality is used only in
case of {{ozShell}} we don't have to expose it through
OzoneVolume/OzoneBucket/OzoneKey.
Test-cases related to oz-shell in {{acceptance-test}} (Robotframework) is
failing, can you please take a look at that too?
We also have to add more test-cases to {{acceptance-test}} (Robotframework) to
cover all the shell commands.
> Ozone: Ozone Shell should use RestClient and RpcClient
> ------------------------------------------------------
>
> Key: HDFS-13431
> URL: https://issues.apache.org/jira/browse/HDFS-13431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDFS-13431-HDFS-7240.001.patch,
> HDFS-13431-HDFS-7240.002.patch, HDFS-13431-HDFS-7240.003.patch,
> HDFS-13431.001.patch, HDFS-13431.002.patch
>
>
> Currently Ozone Shell uses OzoneRestClient. We should use both RestClient and
> RpcClient instead of OzoneRestClient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
