[
https://issues.apache.org/jira/browse/HDFS-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064218#comment-13064218
]
Aaron T. Myers commented on HDFS-2120:
--------------------------------------
Hey John, patch looks pretty good. A few small comments:
# Make sure there's a space between "if" and the open parenthesis.
# No need for the space after "!" in "if (! nsver.equals(stver))"
# I think the variable names "nsver" and "stver" could be more descriptive. Or,
at least, they should be camel cased (capitalize the "v".)
# Would it really be so difficult to write a test for this? Seems like it
wouldn't be too tough to use Mockito to mock out "bpNamenode.versionRequest()"
to return some object with a different version number from the actual.
> on reconnect, DN can connect to NN even with different source versions
> ----------------------------------------------------------------------
>
> Key: HDFS-2120
> URL: https://issues.apache.org/jira/browse/HDFS-2120
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-2120.patch
>
>
> DN or NN does not check for source versions in cases when NN goes away or has
> lost connection. The only check that is done by NN is for LAYOUT_VERSION and
> DN does not check for any version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
