[
https://issues.apache.org/jira/browse/HDFS-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064836#comment-13064836
]
Aaron T. Myers commented on HDFS-2120:
--------------------------------------
Latest patch looks much better, John. Thanks for addressing my comments. A few
more small comments:
# Need license header on the newly-added file.
# Indent the "@Test" annotation.
# When testing that some method throws a specific exception, I prefer to
structure it like so:
{code}
try {
methodWhichThrows();
fail("method didn't throw as expected!");
} catch (ExpectedException e) {
LOG.info("Got expected exception", e);
}
{code}
Once these are addressed, I'll commit this pending Hudson results.
> on reconnect, DN can connect to NN even with different source versions
> ----------------------------------------------------------------------
>
> Key: HDFS-2120
> URL: https://issues.apache.org/jira/browse/HDFS-2120
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-2120-2.patch, HDFS-2120.patch
>
>
> DN or NN does not check for source versions in cases when NN goes away or has
> lost connection. The only check that is done by NN is for LAYOUT_VERSION and
> DN does not check for any version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
