[ 
https://issues.apache.org/jira/browse/HDDS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463897#comment-16463897
 ] 

genericqa commented on HDDS-18:
-------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 8 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
17m  2s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test hadoop-ozone/acceptance-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
57s{color} | {color:red} hadoop-hdds/common in trunk has 1 extant Findbugs 
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
44s{color} | {color:red} hadoop-ozone/ozone-manager in trunk has 1 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
20s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 27m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m  6s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test hadoop-ozone/acceptance-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
52s{color} | {color:red} hadoop-ozone/ozone-manager generated 19 new + 1 
unchanged - 0 fixed = 20 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
15s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
40s{color} | {color:green} ozone-manager in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 39s{color} 
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
24s{color} | {color:green} hadoop-ozone in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
27s{color} | {color:green} acceptance-test in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
43s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}164m 11s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-ozone/ozone-manager |
|  |  Unread field:CreateBucketHandler.java:[line 79] |
|  |  Unread field:DeleteBucketHandler.java:[line 76] |
|  |  Unread field:InfoBucketHandler.java:[line 80] |
|  |  Unread field:ListBucketHandler.java:[line 80] |
|  |  Format-string method java.io.PrintStream.printf(String, Object[]) called 
with format string "Found :with format string "Found : %n buckets for volume : 
%s " wants 1 arguments but is given 2 in 
org.apache.hadoop.ozone.web.ozShell.bucket.ListBucketHandler.execute(CommandLine)
  At ListBucketHandler.java:[line 112] |
|  |  Unread field:UpdateBucketHandler.java:[line 74] |
|  |  Unread field:DeleteKeyHandler.java:[line 62] |
|  |  Unread field:GetKeyHandler.java:[line 79] |
|  |  Unread field:InfoKeyHandler.java:[line 60] |
|  |  Unread field:ListKeyHandler.java:[line 99] |
|  |  Format-string method java.io.PrintStream.printf(String, Object[]) called 
with format string "Found :with format string "Found : %n keys for bucket %s in 
volume : %s " wants 2 arguments but is given 3 in 
org.apache.hadoop.ozone.web.ozShell.keys.ListKeyHandler.execute(CommandLine)  
At ListKeyHandler.java:[line 116] |
|  |  Unread field:PutKeyHandler.java:[line 78] |
|  |  Unread field:DeleteVolumeHandler.java:[line 71] |
|  |  Unread field:InfoVolumeHandler.java:[line 69] |
|  |  Unread field:InfoVolumeHandler.java:[line 76] |
|  |  Dead store to ozoneURI in 
org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine)
  At 
ListVolumeHandler.java:org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine)
  At ListVolumeHandler.java:[line 82] |
|  |  Unread field:ListVolumeHandler.java:[line 85] |
|  |  Format-string method java.io.PrintStream.printf(String, Object[]) called 
with format string "Found :with format string "Found : %n volumes for user : %s 
" wants 1 arguments but is given 2 in 
org.apache.hadoop.ozone.web.ozShell.volume.ListVolumeHandler.execute(CommandLine)
  At ListVolumeHandler.java:[line 111] |
|  |  Unread field:UpdateVolumeHandler.java:[line 69] |
| Failed junit tests | hadoop.ozone.web.client.TestKeysRatis |
|   | hadoop.ozone.TestOzoneConfigurationFields |
|   | hadoop.ozone.TestStorageContainerManager |
|   | hadoop.ozone.web.client.TestKeys |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-18 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921930/HDDS-18.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 35b4cd44effa 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13 
13:47:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / a3b416f |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager-warnings.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/artifact/out/new-findbugs-hadoop-ozone_ozone-manager.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/testReport/ |
| Max. process+thread count | 1019 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-ozone/client 
hadoop-ozone/ozone-manager hadoop-ozone/integration-test 
hadoop-tools/hadoop-ozone hadoop-ozone/acceptance-test U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/27/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozone: Ozone Shell should use RestClient and RpcClient
> ------------------------------------------------------
>
>                 Key: HDDS-18
>                 URL: https://issues.apache.org/jira/browse/HDDS-18
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: HDDS-18.001.patch, HDFS-13431-HDFS-7240.001.patch, 
> HDFS-13431-HDFS-7240.002.patch, HDFS-13431-HDFS-7240.003.patch, 
> HDFS-13431.001.patch, HDFS-13431.002.patch
>
>
> Currently Ozone Shell uses OzoneRestClient. We should use both RestClient and 
> RpcClient instead of OzoneRestClient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to