[
https://issues.apache.org/jira/browse/HDDS-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467985#comment-16467985
]
Nanda kumar commented on HDDS-18:
---------------------------------
Thanks [~ljain] for updating the patch. The updated patch looks good to me,
some very minor comments/NITs.
GetKeyHandler:118 Typo {{acccess}}
RestClient:47 Unused import
RestClient:198 Line length greater than 80
OzoneKey:21 & 23 Unused imports, there are no other changes in this file.
OzoneClientUtils: javadoc missing for the class, some javadoc to methods will
also be useful
OzoneClientUtils: Since it's a utility class mark this as final and add a
private constructor
OzoneClientUtils:33, 36 & 42 line length greater than 80
ListVolumeHandler:33 Unused import
InfoKeyHandler:28 import statement should be expanded
> Ozone: Ozone Shell should use RestClient and RpcClient
> ------------------------------------------------------
>
> Key: HDDS-18
> URL: https://issues.apache.org/jira/browse/HDDS-18
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-18.001.patch, HDDS-18.002.patch,
> HDFS-13431-HDFS-7240.001.patch, HDFS-13431-HDFS-7240.002.patch,
> HDFS-13431-HDFS-7240.003.patch, HDFS-13431.001.patch, HDFS-13431.002.patch
>
>
> Currently Ozone Shell uses OzoneRestClient. We should use both RestClient and
> RpcClient instead of OzoneRestClient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
