[ 
https://issues.apache.org/jira/browse/HDDS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463995#comment-16463995
 ] 

Nanda kumar commented on HDDS-17:
---------------------------------

Thanks [~anu] for working on this. The patch looks good to me, some minor 
suggestions.
* Instead of {{Long}} we can use 
{{org.apache.hadoop.hdds.scm.container.ContainerID}}
* In {{Node2ContainerMap#updateDatanodeMap}} can we throw exception if the node 
is not already present.

> Add node to container map class to simplify state in SCM
> --------------------------------------------------------
>
>                 Key: HDDS-17
>                 URL: https://issues.apache.org/jira/browse/HDDS-17
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-17.001.patch
>
>
> Current SCM state map is maintained in nodeStateManager. This first of 
> several refactoring to make it independent and small classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to