[
https://issues.apache.org/jira/browse/HDDS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472870#comment-16472870
]
Anu Engineer commented on HDDS-17:
----------------------------------
[~xyao] Thank you for the comments. Patch v3 addresses all the comments. Please
see below for the details.
{quote}Line 41: "positive int' should be "positive long"
{quote}
Good catch, fixed.
{quote}Line 70: Should we use atomic APIs offered by ConcurrentHashMap like
putIfAbsent, etc.
{quote}
Fixed.
{quote}Line 99: How do we plan to share the cycle for further report (like
size/stats update)
{quote}
It will be managed by the {{ContainerStateMap}}
{quote}Line 155: same as Line 70.
{quote}
Fixed.
{quote} Line 159: Should we return an immutable collection here?
{quote}
Done.
It also fixed the findbug issues and a big test case has been broken into 4
smaller test cases to make it easy to reason about in case of failures.
> Add node to container map class to simplify state in SCM
> --------------------------------------------------------
>
> Key: HDDS-17
> URL: https://issues.apache.org/jira/browse/HDDS-17
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-17.001.patch, HDDS-17.002.patch, HDDS-17.003.patch
>
>
> Current SCM state map is maintained in nodeStateManager. This first of
> several refactoring to make it independent and small classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
