[
https://issues.apache.org/jira/browse/HDDS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471455#comment-16471455
]
Mukul Kumar Singh commented on HDDS-21:
---------------------------------------
Thanks for working on this [~ljain]. The patch looks really good to me.
Please find my review comment as following.
1) KeyHandler.java:254, there is an extra "-" in the javadoc.
2) Key parsing path should not be changed from "/{volume}/{bucket}/{keys:.*}"
this will not let the RestServer manage keys of type
"/vol/bucket/keynamepart1/keynamepart2"
i.e. key names which are delimited by "/". I feel for renames, we should pass
the toname as an argument to the rest request. This can be done using
"builder.addParameter" in RestClient.
> Ozone: Add support for rename key within a bucket for rest client
> -----------------------------------------------------------------
>
> Key: HDDS-21
> URL: https://issues.apache.org/jira/browse/HDDS-21
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-21.001.patch, HDDS-21.002.patch,
> HDFS-13229-HDFS-7240.001.patch
>
>
> This jira aims to add support for rename key within a bucket for rest client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
