[ 
https://issues.apache.org/jira/browse/HDDS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472278#comment-16472278
 ] 

Mukul Kumar Singh commented on HDDS-21:
---------------------------------------

Thanks for the updated patch [~ljain]. The v3 patch looks really good to me. 
Some minor comments, I am +1 after that.

1) Header.java: 68, lets name the variable as  OZONE_RENAME_TO_KEY_PARAM_NAME
2) TestOzoneRestClient:392 - lets move lines 418-419 before the expected 
exception message, so that all the statements are executed.
3) KeyHandler.java:254 - please remove the extra "-" in the javadoc.



> Ozone: Add support for rename key within a bucket for rest client
> -----------------------------------------------------------------
>
>                 Key: HDDS-21
>                 URL: https://issues.apache.org/jira/browse/HDDS-21
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: HDDS-21.001.patch, HDDS-21.002.patch, HDDS-21.003.patch, 
> HDFS-13229-HDFS-7240.001.patch
>
>
> This jira aims to add support for rename key within a bucket for rest client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to