[
https://issues.apache.org/jira/browse/HDDS-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471702#comment-16471702
]
Shashikant Banerjee commented on HDDS-25:
-----------------------------------------
Thanks [~elek], for updating the patch. The patch looks good to me overall.
Some nitpicks:
1.EventQueue.java : 37 : Incorrect spelling for incoming
2.EventQueue.java : 87 : Incorrect javadoc
3.EventQueue.java : 123 : The javadoc comment should be "don't use it for
production code".
4..EventQueue.java : 128: "handler" in the comment should be "handled".
Apart from this, there can be case where an event handler can get stuck
indefinitely because of deadlock etc, there should be a way to cancel the event
and report. Also, in case there are chain of events getting triggered post one
event, we should have a way to trace all the events in order in case it gets
stuck while handling one event in the chain. Also, i think we can have a
priority based event queue.
These does not necessarily be addressed in the Jira here. Just some high level
thoughts.
> Simple async event processing for SCM
> -------------------------------------
>
> Key: HDDS-25
> URL: https://issues.apache.org/jira/browse/HDDS-25
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-25.001.patch, HDDS-25.003.patch, HDDS-25.004.patch
>
>
> For implementing all the SCM status changes we need a simple async event
> processing.
> Our use-case is very similar to an actor based system: we would like to
> communicate with full asny event/messages, process the different events on
> different threads, ...
> But a full Actor framework (such as Akka) would be overkill for this use
> case. We don't need distributed actor systems, actor hierarchy or complex
> resiliency.
> As a first approach we can use a very simple system where a common EventQueue
> entry point could route events to the async event handlers
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
