[
https://issues.apache.org/jira/browse/HDDS-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472513#comment-16472513
]
Xiaoyu Yao commented on HDDS-25:
--------------------------------
Thanks [~elek] for working on this. Sorry, I'm late in the review.
The patch looks good to me. I just have few comments that we can address in
follow up JIRAs.
EventQueue.java
Line 144/166: the counter processed is not updated during the loop.
We can calculate and update it around line 148. Otherwise, it is always 0.
Line 179: you might want to try it multiple times and enforce a timeout for the
executor close.
Some badly designed JVM shutdown hooks could make the executor close wait
forever.
> Simple async event processing for SCM
> -------------------------------------
>
> Key: HDDS-25
> URL: https://issues.apache.org/jira/browse/HDDS-25
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-25.001.patch, HDDS-25.003.patch, HDDS-25.004.patch,
> HDDS-25.005.patch
>
>
> For implementing all the SCM status changes we need a simple async event
> processing.
> Our use-case is very similar to an actor based system: we would like to
> communicate with full asny event/messages, process the different events on
> different threads, ...
> But a full Actor framework (such as Akka) would be overkill for this use
> case. We don't need distributed actor systems, actor hierarchy or complex
> resiliency.
> As a first approach we can use a very simple system where a common EventQueue
> entry point could route events to the async event handlers
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
