[ 
https://issues.apache.org/jira/browse/HDFS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065740#comment-13065740
 ] 

Aaron T. Myers commented on HDFS-2152:
--------------------------------------

Hey Uma, patch looks pretty good. One small comment:

# I think you should leave in the "{{os.close()}}" call, and then just set 
{{os}} to null. I say that because relying only on {{IOUtils.cleanup(...)}} to 
do the close will swallow a legitimate error.

I'll commit it pending that issue being addressed and Hudson results.

> TestWriteConfigurationToDFS causing the random failures
> -------------------------------------------------------
>
>                 Key: HDFS-2152
>                 URL: https://issues.apache.org/jira/browse/HDFS-2152
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2152.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to