[
https://issues.apache.org/jira/browse/HDFS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065908#comment-13065908
]
Uma Maheswara Rao G commented on HDFS-2152:
-------------------------------------------
Hi Aaron,
Thanks alot for taking a look.
{quote}
I think you should leave in the "os.close()" call, and then just set os to
null. I say that because relying only on IOUtils.cleanup(...) to do the close
will swallow a legitimate error.
{quote}
Got you.:-) . you are suggesting the similar(HADOOP-7090) pattern right? I
thought IOUtils.cleanup will be enough for tests. You are right, Even in tests,
this will be good approach to follow.Otherwise we may not know some of the
exceptions while closing, due to suppression in IOUtils..cleanup.
Patch incorporates Aaron comments.
> TestWriteConfigurationToDFS causing the random failures
> -------------------------------------------------------
>
> Key: HDFS-2152
> URL: https://issues.apache.org/jira/browse/HDFS-2152
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2152-1.patch, HDFS-2152.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
