[
https://issues.apache.org/jira/browse/HDFS-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479148#comment-16479148
]
Erik Krogen commented on HDFS-13578:
------------------------------------
One point I want to bring up is the case of {{getBlockLocations()}} - we
definitely want it to be performed on the observer, but it is not technically
read-only since it might update the access time. Given that this is the only
exception (that I can think of), it is probably fine. Notably,
{{getBlockLocations()}} is also marked with {{@Idempotent}} even though it is
technically not, also because of the access time.
> Add ReadOnly annotation to methods in ClientProtocol
> ----------------------------------------------------
>
> Key: HDFS-13578
> URL: https://issues.apache.org/jira/browse/HDFS-13578
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13578-HDFS-12943.000.patch
>
>
> For those read-only methods in {{ClientProtocol}}, we may want to use a
> {{@ReadOnly}} annotation to mark them, and then check in the proxy provider
> for observer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
