[
https://issues.apache.org/jira/browse/HDFS-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488091#comment-16488091
]
Chao Sun commented on HDFS-13578:
---------------------------------
Thanks [~elgoiri]. Regarding:
{code}
for (Method m : allMethods) {
boolean expected = readOnlyMethodNames.contains(m.getName());
checkIsReadOnly(m.getName(), expected);
}
{code}
I only want to call {{checkIsReadOnly}} for those methods that are not readonly
in this loop, but the above change will invoke it for all the methods.
For {{getBlockLocations()}}, I think we should allow this but suggest users to
disable atime for better performance. HDFS-13602 can help to reduce the impact
too. Checking atime seems undesirable as it means to disable
{{getBlockLocations()}} from observer completely if atime is enabled?
> Add ReadOnly annotation to methods in ClientProtocol
> ----------------------------------------------------
>
> Key: HDFS-13578
> URL: https://issues.apache.org/jira/browse/HDFS-13578
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13578-HDFS-12943.000.patch,
> HDFS-13578-HDFS-12943.001.patch
>
>
> For those read-only methods in {{ClientProtocol}}, we may want to use a
> {{@ReadOnly}} annotation to mark them, and then check in the proxy provider
> for observer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
