[
https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486777#comment-16486777
]
Andrew Wang commented on HDFS-13601:
------------------------------------
Thanks for reviewing Xiao! I think this current behavior is actually no
different than the existing PBHelperClient, since it calls
\{{setPoolId(b.getBlockPoolId())}} without a null check, and setPoolId will
throw an NPE if the value is null. I can add the null check if you want, but
since the behavior is the same as the existing code I think it's okay.
I also ran the failed tests locally and they passed, so I think they're flakes.
> Optimize ByteString conversions in PBHelper
> -------------------------------------------
>
> Key: HDFS-13601
> URL: https://issues.apache.org/jira/browse/HDFS-13601
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.1.0, 2.9.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Major
> Attachments: HDFS-13601.001.patch, HDFS-13601.002.patch,
> HDFS-13601.003.patch, HDFS-13601.004.patch
>
>
> While doing some profiling of the NN with JMC, I saw a lot of time being
> spent on String->ByteString conversions. These are often the same strings
> being converted over and over again, meaning there's room for optimization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
