[ 
https://issues.apache.org/jira/browse/HDFS-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486786#comment-16486786
 ] 

Xiao Chen commented on HDFS-13601:
----------------------------------

{quote}setPoolId will throw an NPE if the value is null
{quote}
I'm okay with patch 4 as-is then. :) 

> Optimize ByteString conversions in PBHelper
> -------------------------------------------
>
>                 Key: HDFS-13601
>                 URL: https://issues.apache.org/jira/browse/HDFS-13601
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.1.0, 2.9.1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Major
>         Attachments: HDFS-13601.001.patch, HDFS-13601.002.patch, 
> HDFS-13601.003.patch, HDFS-13601.004.patch
>
>
> While doing some profiling of the NN with JMC, I saw a lot of time being 
> spent on String->ByteString conversions. These are often the same strings 
> being converted over and over again, meaning there's room for optimization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to