[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491863#comment-16491863
]
Konstantin Shvachko commented on HDFS-13399:
--------------------------------------------
Looked at your patch Plamen. Still think it would have been easier to get your
tests in if {{StandbyReadProxyProvider}} had been implemented already. But oh
well. Few suggestions:
# Unused import in {{NameNodeHAProxyFactory}}. Glad that you don't need to
change this class at all.
# Would be good to leave {{HAProxyFactory}} unchanged, and add
{{setAlignmentContext()}} only to {{ClientHAProxyFactory}}. It is fine to cast
{{factory}} to {{ClientHAProxyFactory<T>}} in
{{AlignmentContextProxyProvider()}} constructor in the test.
# Could we call the new method
{{NameNodeProxiesClient.createNonHAProxyWithClientProtocol(...,
alignmentContext)}} with the context parameter simply
{{createProxyWithClientProtocol()}} or something. createHA and crateNonHA are
really confusing to me at this point.
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch, HDFS-13399-HDFS-12943.002.patch,
> HDFS-13399-HDFS-12943.003.patch, HDFS-13399-HDFS-12943.004.patch,
> HDFS-13399-HDFS-12943.005.patch, HDFS-13399-HDFS-12943.006.patch,
> HDFS-13399-HDFS-12943.007.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
