[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498592#comment-16498592
]
Konstantin Shvachko commented on HDFS-13399:
--------------------------------------------
I think we got wrong build links. Here is the right one:
https://builds.apache.org/job/PreCommit-HDFS-Build/24325/artifact/out/diff-checkstyle-root.txt
Pasting the checkstyle warnings:
{nofrmat}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:341:
AlignmentContext alignmentContext;:22: Variable 'alignmentContext' must be
private and have accessor methods. [VisibilityModifier]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:592:
/**: First sentence should end with a period. [JavadocStyle]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:610:
public static <T> ProtocolProxy<T> getProtocolProxy(Class<T> protocol,:
'method def modifier' has incorrect indentation level 3, expected level should
be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:610:
public static <T> ProtocolProxy<T> getProtocolProxy(Class<T> protocol,:39:
More than 7 parameters (found 10). [ParameterNumber]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:837:
RpcResponseHeaderProto bufferedHeader; // the response header for
call:28: Variable 'bufferedHeader' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:838:
Writable bufferedRv; // the byte response for call:14:
Variable 'bufferedRv' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java:219:
public Invoker(Class<?> protocol,:12: More than 7 parameters (found 8).
[ParameterNumber]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestStateAlignmentContextWithHA.java:35:import
org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider;:8: Unused
import - org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider.
[UnusedImports]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestStateAlignmentContextWithHA.java:86:
public AlignmentContextProxyProvider(:5: Redundant 'public' modifier.
[RedundantModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestStateAlignmentContextWithHA.java:110:
public SpyConfiguredContextProxyProvider(:5: Redundant 'public' modifier.
[RedundantModifier]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestStateAlignmentContextWithHA.java:220:
long clientState = getContext(0).getLastSeenStateId();;:59: Empty
statement. [EmptyStatement]
{nofrmat}
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch, HDFS-13399-HDFS-12943.002.patch,
> HDFS-13399-HDFS-12943.003.patch, HDFS-13399-HDFS-12943.004.patch,
> HDFS-13399-HDFS-12943.005.patch, HDFS-13399-HDFS-12943.006.patch,
> HDFS-13399-HDFS-12943.007.patch, HDFS-13399-HDFS-12943.008.patch,
> HDFS-13399-HDFS-12943.009.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
