[
https://issues.apache.org/jira/browse/HDFS-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501302#comment-16501302
]
Ekanth S commented on HDFS-13653:
---------------------------------
[~elgoiri], thanks for the quick review. I did think about unit tests when
writing the patch. Since this is a private method that is about randomness, it
isn't easy to unit test this as any expectation would be unpredictable (say
from what getProxy would return for example). There are tests in
TestDFSClientFailover.java that test this code path to make sure the basic
functionality works as in calling getRandomOrder() as part of constructing
ConfiguredFailoverProxyProvider. However, I am open to ideas to test this. Let
me know if you have specific guidance here.
On the style check, it appears okay after the yetus run. I did notice other
methods with params that do not have a period at the end. So I guess it is okay
as it is?
> Make dfs.client.failover.random.order a per nameservice configuration
> ---------------------------------------------------------------------
>
> Key: HDFS-13653
> URL: https://issues.apache.org/jira/browse/HDFS-13653
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Reporter: Ekanth S
> Assignee: Ekanth S
> Priority: Major
> Attachments: HDFS-13653.001.patch
>
>
> Currently the dfs.client.failover.random.order is applied globally. If we
> have a combination of router and non-router nameservice, the random order
> should ideally be enabled only for the router based nameservice. This Jira is
> to make this configuration per-nameservice so that this can be configured
> independently for each nameservice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
