[
https://issues.apache.org/jira/browse/HDFS-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502760#comment-16502760
]
Ekanth Sethuramalingam commented on HDFS-13653:
-----------------------------------------------
Thanks [~elgoiri] for the comments. Addressed 3 of the 4 comments. Also handled
a bunch of checkstyle errors that came through yetus run.
* It could use some refactoring, currently it has 3 mocks that are pretty much
the same in a couple test cases.
Could you help understand what you meant here? Each of the mock is a closure on
an unique atomicInteger corresponding to the mock. Let me know how I can better
refactor this. Attached new patch: [^HDFS-13653.006.patch].
Also the unit test failures seem unrelated as all the changes in the recent
patch was only addition of new UTs. So I guess they are already flaky?
> Make dfs.client.failover.random.order a per nameservice configuration
> ---------------------------------------------------------------------
>
> Key: HDFS-13653
> URL: https://issues.apache.org/jira/browse/HDFS-13653
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Reporter: Ekanth Sethuramalingam
> Assignee: Ekanth Sethuramalingam
> Priority: Major
> Attachments: HDFS-13653.001.patch, HDFS-13653.002.patch,
> HDFS-13653.003.patch, HDFS-13653.004.patch, HDFS-13653.005.patch,
> HDFS-13653.006.patch
>
>
> Currently the dfs.client.failover.random.order is applied globally. If we
> have a combination of router and non-router nameservice, the random order
> should ideally be enabled only for the router based nameservice. This Jira is
> to make this configuration per-nameservice so that this can be configured
> independently for each nameservice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
