[ 
https://issues.apache.org/jira/browse/HDFS-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511874#comment-16511874
 ] 

Íñigo Goiri commented on HDFS-13676:
------------------------------------

Thanks [~zuzhan] for the patch.
I think the fix is correct.
I don't quite get why those two lines were commented in HDFS-7964.
[~daryn], do you know why those two lines were commented?
It looks like it was removed on the patches after October 2015 but from the 
discussion I cannot get why.


> TestEditLogRace fails on Windows
> --------------------------------
>
>                 Key: HDFS-13676
>                 URL: https://issues.apache.org/jira/browse/HDFS-13676
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.1.0, 2.9.1
>            Reporter: Zuoming Zhang
>            Assignee: Zuoming Zhang
>            Priority: Minor
>              Labels: Windows
>             Fix For: 3.1.0, 2.9.1
>
>         Attachments: HDFS-13676.000.patch, TestEditLogRace-Report.000.txt
>
>
> _TestEditLogRace_ fails on Windows
>  
> Problem:
> When try to call _FSImage.saveFSImageInAllDirs_, there's actually no 
> directories existing. This is because the _getConf()_ function doesn't 
> specify creating any directories.
>  
> Fix:
> Remove the comment for the two lines that config directories to be created.
>  
> Concern:
> Not for sure why it was commented in change 
> [https://github.com/apache/hadoop/commit/3cb7ae11a839c01b8be629774874c1873f51b747]
>  And it should also fail for Linux I guess.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to