[
https://issues.apache.org/jira/browse/HDFS-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514043#comment-16514043
]
Íñigo Goiri commented on HDFS-13676:
------------------------------------
[^HDFS-13676.001.patch] looks good now.
As [~zuzhan] said, the failures don't seem related.
Which patch applies to which branches?
branch-2 and branch-2.9 use [^HDFS-13676-branch-2.000.patch] for sure but I'm
not sure when the change for [^HDFS-13676.001.patch] kicked in.
+1
I'll hold this to give a chance for [~daryn] to double check.
I think the code was wrongly commented but I'd like to double check.
> TestEditLogRace fails on Windows
> --------------------------------
>
> Key: HDFS-13676
> URL: https://issues.apache.org/jira/browse/HDFS-13676
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.1.0, 2.9.1
> Reporter: Zuoming Zhang
> Assignee: Zuoming Zhang
> Priority: Minor
> Labels: Windows
> Attachments: HDFS-13676-branch-2.000.patch, HDFS-13676.000.patch,
> HDFS-13676.001.patch, TestEditLogRace-Report-branch-2.001.txt,
> TestEditLogRace-Report.000.txt
>
>
> _TestEditLogRace_ fails on Windows
>
> Problem:
> When try to call _FSImage.saveFSImageInAllDirs_, there's actually no
> directories existing. This is because the _getConf()_ function doesn't
> specify creating any directories.
>
> Fix:
> Remove the comment for the two lines that config directories to be created.
>
> Concern:
> Not for sure why it was commented in change
> [https://github.com/apache/hadoop/commit/3cb7ae11a839c01b8be629774874c1873f51b747]
> And it should also fail for Linux I guess.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
