[
https://issues.apache.org/jira/browse/HDDS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515973#comment-16515973
]
Xiaoyu Yao commented on HDDS-169:
---------------------------------
Thanks [~bharatviswa] for working on this. The patch looks good to me overall.
Just two minor comments:
ChunkManagerImpl.java
Line 172: should we increment the readTime around here for the volume io stat?
ChunkUtils.java
Line 66/144: should we make the util consistent by passing/returning
volumeiostats for read/write?
> Add Volume IO Stats
> --------------------
>
> Key: HDDS-169
> URL: https://issues.apache.org/jira/browse/HDDS-169
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-169-HDDS-48.00.patch
>
>
> This Jira is used to add VolumeIO stats in the datanode.
> Add IO calculations for Chunk operations.
> readBytes, readOpCount, writeBytes, writeOpCount, readTime, writeTime.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]