[ 
https://issues.apache.org/jira/browse/HDDS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516538#comment-16516538
 ] 

Bharat Viswanadham commented on HDDS-169:
-----------------------------------------

 Hi [~xyao]

Thanks for the review.

I have addressed the review comments.

 
{quote}ChunkManagerImpl.java

Line 172: should we increment the readTime around here for the volume io stat?
{quote}
readTime, I have incremented it after read data from the file, just before 
returning data. Let me know if you still want it changed?

ChunkUtils.java Line 168-169

file.read(buf, data.getOffset()).get();
volumeIOStats.incReadTime(Time.monotonicNow() - timeTaken);

> Add Volume IO Stats 
> --------------------
>
>                 Key: HDDS-169
>                 URL: https://issues.apache.org/jira/browse/HDDS-169
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-169-HDDS-48.00.patch, HDDS-169-HDDS-48.01.patch
>
>
> This Jira is used to add VolumeIO stats in the datanode.
> Add IO calculations for Chunk operations.
> readBytes, readOpCount, writeBytes, writeOpCount, readTime, writeTime.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to