[ 
https://issues.apache.org/jira/browse/HDFS-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519923#comment-16519923
 ] 

Konstantin Shvachko commented on HDFS-13609:
--------------------------------------------

Very comprehensive analysis [~xkrogen].
I was looking at {{BackupImage.tryConvergeJournalSpool()}}. Remembered some 
details. The spool in BackupNode context is an edits where BackupNode writes 
transactions received from NN during checkpointing the image, because ut cannot 
apply them to the memory state while writing the image. After completing the 
image write, BN reads the edits it saved, this is called 
{{convergeJournalSpool()}}. Since BN uses only EditLogFileStreams the effect of 
the optimization parameter should be completely ignored.
Anyways I checked and run {{TestBackupNode}} with both {{optimizeLatency = 
true}} and {{false}} and it passed.
I think it is safe to use the single parameter in this case.

> [Edit Tail Fast Path Pt 3] NameNode-side changes to support tailing edits via 
> RPC
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-13609
>                 URL: https://issues.apache.org/jira/browse/HDFS-13609
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>         Attachments: HDFS-13609-HDFS-12943.000.patch, 
> HDFS-13609-HDFS-12943.001.patch, HDFS-13609-HDFS-12943.002.patch
>
>
> See HDFS-13150 for the full design.
> This JIRA is targetted at the NameNode-side changes to enable tailing 
> in-progress edits via the RPC mechanism added in HDFS-13608. Most changes are 
> in the QuorumJournalManager.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to