[ 
https://issues.apache.org/jira/browse/HDFS-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520734#comment-16520734
 ] 

Erik Krogen commented on HDFS-13609:
------------------------------------

Thanks for looking at {{BackupImage}} [~shv]! I had no idea what was happening 
there :) I have removed this extra parameter altogether; now on the QJM 
{{optimizeLatency == inProgressOK}}. This reduced the scope of changes 
significantly.

[~linyiqun], thanks for taking a look! I agree with you on the Precondition 
check; I have incorporated into v003. For your second comment, it should be {{ 
< 0 }}. A return value of {{highestTxnCount == 0}} is expected behavior if you 
have read all available edits and continue to request more; this is not an 
error situation, while seeing a value {{ < 0 }} is an error. Let me know if you 
disagree.

Uploaded v003 patch incorporating all of [~shv] and [~linyiqun]'s comments.

> [Edit Tail Fast Path Pt 3] NameNode-side changes to support tailing edits via 
> RPC
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-13609
>                 URL: https://issues.apache.org/jira/browse/HDFS-13609
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>         Attachments: HDFS-13609-HDFS-12943.000.patch, 
> HDFS-13609-HDFS-12943.001.patch, HDFS-13609-HDFS-12943.002.patch, 
> HDFS-13609-HDFS-12943.003.patch
>
>
> See HDFS-13150 for the full design.
> This JIRA is targetted at the NameNode-side changes to enable tailing 
> in-progress edits via the RPC mechanism added in HDFS-13608. Most changes are 
> in the QuorumJournalManager.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to