[
https://issues.apache.org/jira/browse/HDDS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522894#comment-16522894
]
Hanisha Koneru commented on HDDS-173:
-------------------------------------
Thanks for the review, [~bharatviswa].
Addressed the comments in patch v02.
{quote}1. This is added (optional ContainerType containerType = 20 )to
ContainerCommandRequestProto, and it is only set during createContainer, This
is used in HDDSDispatcher to send the request to specific handler. So, can we
make default as KeyValueContainer, so that it is not needed to set for other
requests?
{quote}
I have removed ContainerType from ContainerCommandRequestProto. This will only
be specified in CreateContainerRequestProto now. I made changes to
HddsDispatcher to get the containerType from the container object.
{quote}7. Line 398: deleteChunk does not throw IOException, do we need this?
Same comment applicable for other chunk related operations. {quote}
{{ChunkInfo.getFromProtoBuf}} throws an IOException. So need to handle that
exception here.
{quote}9. In handleCreateContainer, do we need to check whether this container
already exists before createContainer, by calling
containerset.getContainer?{quote}
{{containerSet.addContainer()}} checks that the containerID is not present
already in the set. Updated to throw and propagate the error.
> Refactor Dispatcher and implement Handler for new ContainerIO design
> --------------------------------------------------------------------
>
> Key: HDDS-173
> URL: https://issues.apache.org/jira/browse/HDDS-173
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-173-HDDS-48.001.patch, HDDS-173-HDDS-48.002.patch
>
>
> Dispatcher will pass the ContainerCommandRequests to the corresponding
> Handler based on the ContainerType. Each ContainerType will have its own
> Handler. The Handler class will process the message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
