[
https://issues.apache.org/jira/browse/HDDS-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526774#comment-16526774
]
Nanda kumar commented on HDDS-198:
----------------------------------
Thanks [~dineshchitlangia] for working on this. The patch looks pretty good to
me, some very minor comments.
AuditAction.java
We cannot enforce {{toString}} method using interface. Can you rename it to
something like {{getAction}} or {{getOperation}}?
AuditLogger.java
{{initializeLogger}} can be made private.
Auditable interface is not used anywhere, Am I missing something?
> Create AuditLogger mechanism to be used by OM, SCM and Datanode
> ---------------------------------------------------------------
>
> Key: HDDS-198
> URL: https://issues.apache.org/jira/browse/HDDS-198
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: audit, log4j2
> Fix For: 0.2.1
>
> Attachments: HDDS-198.001.patch
>
>
> This Jira tracks the work to create a custom AuditLogger which can be used by
> OM, SCM, Datanode for auditing read/write events.
> The AuditLogger will be designed using log4j2 and leveraging the MarkerFilter
> approach to be able to turn on/off audit of read/write events by simply
> changing the log config.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
