[
https://issues.apache.org/jira/browse/HDDS-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530373#comment-16530373
]
Dinesh Chitlangia commented on HDDS-198:
----------------------------------------
[~ajayydv] - Thank you for a comprehensive review. I have incorporated changes
as advised except the following:
* VerifyLog L108: We can get rid of try catch and throw any exception.
** VerifyLog is being called by each test method and would lead to repetition
of code if it throws an exception. Thus, catching and logging it in verifyLog()
itself.
* DummyAction and OMAction looks pretty identical. Either we can use OMAction
for test cases as well or just extend it in inner class inside related
TestClass.
** As discussed, the OMAction is placed under hadoop-ozone and the entire
audit changes/tests are placed in HDDS project. Thus, I had to create a
DummyAction for test purpose. OMAction is intended for use in future when Audit
logging related changes are made for OM.
[~xyao], [~nandakumar131], [~anu] - Please feel free to review and advise
further improvements as needed.
> Create AuditLogger mechanism to be used by OM, SCM and Datanode
> ---------------------------------------------------------------
>
> Key: HDDS-198
> URL: https://issues.apache.org/jira/browse/HDDS-198
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: audit, log4j2
> Fix For: 0.2.1
>
> Attachments: HDDS-198.001.patch, HDDS-198.002.patch,
> HDDS-198.003.patch, HDDS-198.004.patch
>
>
> This Jira tracks the work to create a custom AuditLogger which can be used by
> OM, SCM, Datanode for auditing read/write events.
> The AuditLogger will be designed using log4j2 and leveraging the MarkerFilter
> approach to be able to turn on/off audit of read/write events by simply
> changing the log config.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
