[
https://issues.apache.org/jira/browse/HDFS-13710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532365#comment-16532365
]
yanghuafeng edited comment on HDFS-13710 at 7/4/18 7:17 AM:
------------------------------------------------------------
{{Thanks for your nits.}}
{quote}I'm not sure there is a point starting a full cluster just for this.
{{I think we should just start a Router and mock whatever is needed.}}
{quote}
{{You are right. I have replaced the cluster with the router to test the case.
And the time spent is much less than the former. }}
{quote}I'm not sure there's a point having this comment
{quote}
{{the comments indeed does not matter. To make the code clean and simple, I
removed the comments.}}
{quote}We should do the checkOperation as the first operation even if the quota
is not enabled.
{quote}
I have adjusted the order of the operations
Please review the code again, [~linyiqun] [~elgoiri]
was (Author: hfyang20071):
{{Thanks for your nits.}}
{{{quote} }}
{{I'm not sure there is a point starting a full cluster just for this.}}
{{I think we should just start a Router and mock whatever is needed.}}
{{{quote}}}
{{You are right. I have replaced the cluster with the router to test the case.
And the time spent is much less than the former. }}
{{{quote} }}
I'm not sure there's a point having this comment
{{{quote}}}
{{the comments indeed does not matter. To make the code clean and simple, I
removed the comments.}}
{{{quote} }}
We should do the checkOperation as the first operation even if the quota is not
enabled.
{{{quote}}}
I have adjusted the order of the operations.
Please review the code again, [~linyiqun] [~elgoiri]
> RBF: setQuota and getQuotaUsage should check the
> dfs.federation.router.quota.enable
> ------------------------------------------------------------------------------------
>
> Key: HDFS-13710
> URL: https://issues.apache.org/jira/browse/HDFS-13710
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: federation, hdfs
> Affects Versions: 2.9.1, 3.0.3
> Reporter: yanghuafeng
> Priority: Major
> Attachments: HDFS-13710.002.patch, HDFS-13710.003.patch,
> HDFS-13710.004.patch, HDFS-13710.005.patch, HDFS-13710.006.patch,
> HDFS-13710.patch
>
>
> when I use the command below, some exceptions happened.
>
> {code:java}
> hdfs dfsrouteradmin -setQuota /tmp -ssQuota 1G
> {code}
> the logs follow.
> {code:java}
> Successfully set quota for mount point /tmp
> {code}
> It looks like the quota is set successfully, but some exceptions happen in
> the rbf server log.
> {code:java}
> java.io.IOException: No remote locations available
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:1002)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:967)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:940)
> at
> org.apache.hadoop.hdfs.server.federation.router.Quota.setQuota(Quota.java:84)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterAdminServer.synchronizeQuota(RouterAdminServer.java:255)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterAdminServer.updateMountTableEntry(RouterAdminServer.java:238)
> at
> org.apache.hadoop.hdfs.protocolPB.RouterAdminProtocolServerSideTranslatorPB.updateMountTableEntry(RouterAdminProtocolServerSideTranslatorPB.java:179)
> at
> org.apache.hadoop.hdfs.protocol.proto.RouterProtocolProtos$RouterAdminProtocolService$2.callBlockingMethod(RouterProtocolProtos.java:259)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:616)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:982)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2115)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2111)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1867)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2111)
> {code}
> I find the dfs.federation.router.quota.enable is false by default. And it
> causes the problem. I think we should check the parameter when we call
> setQuota and getQuotaUsage.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
