[
https://issues.apache.org/jira/browse/HDDS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533982#comment-16533982
]
Xiaoyu Yao commented on HDDS-187:
---------------------------------
Thanks [~ajayydv] for the update. The patch v6 looks good to me. I just have
three minor comments:
*HddsIdFactory.java*
*Line 37:* Time.monotonicNowNanos() may not be a good choice for cmd id. For
example, when the cmds are issiued simultaneously, you may get the same id
from multiple cmds, which might cause problem with the cmdStatusMap in
*StateContext class*. Have you consider extend SequentialNumber class like we
do for the HDFS block id?
*Line 45: should this be static as we have a private contructor here?*
*Jenkins 2 java doc issues.*
> Command status publisher for datanode
> -------------------------------------
>
> Key: HDDS-187
> URL: https://issues.apache.org/jira/browse/HDDS-187
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-187.00.patch, HDDS-187.01.patch, HDDS-187.02.patch,
> HDDS-187.03.patch, HDDS-187.04.patch, HDDS-187.05.patch, HDDS-187.06.patch
>
>
> Currently SCM sends set of commands for DataNode. DataNode executes them via
> CommandHandler. This jira intends to create a Command status publisher which
> will return status of these commands back to the SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
