[ https://issues.apache.org/jira/browse/HDDS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534294#comment-16534294 ]
Ajay Kumar commented on HDDS-187: --------------------------------- [~xyao] thanks for review. {quote}HddsIdFactory.java Time.monotonicNowNanos may not be a good choice for cmd id. {quote} Replaced it with an AtmoicLong which is initialized with System time. In theory this may return non unique id's if id's are generated faster than nano time and system restart happens with same pace but IMO this will not impact our use case. {quote}Line 45: should this be static as we have a private contructor here?{quote} done {quote}Jenkins 2 java doc issues.{quote} done > Command status publisher for datanode > ------------------------------------- > > Key: HDDS-187 > URL: https://issues.apache.org/jira/browse/HDDS-187 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: SCM > Affects Versions: 0.2.1 > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-187.00.patch, HDDS-187.01.patch, HDDS-187.02.patch, > HDDS-187.03.patch, HDDS-187.04.patch, HDDS-187.05.patch, HDDS-187.06.patch, > HDDS-187.07.patch > > > Currently SCM sends set of commands for DataNode. DataNode executes them via > CommandHandler. This jira intends to create a Command status publisher which > will return status of these commands back to the SCM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org