[
https://issues.apache.org/jira/browse/HDDS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543453#comment-16543453
]
Bharat Viswanadham commented on HDDS-250:
-----------------------------------------
Hi [~hanishakoneru]
Thanks for the updated patch. Looks good to me overall.
One minor comment, can we make getProtoBufMessage as abstract in containerData,
as each ContainerType may override its implementation.
This is not related to the patch, during the review found this.
And also getReadContainerResponse() in ContainerUtil, can be removed as we have
getReadContainerResponse for KV Container in KeyValueContainerLocationUtil.
> Cleanup ContainerData
> ---------------------
>
> Key: HDDS-250
> URL: https://issues.apache.org/jira/browse/HDDS-250
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-250.000.patch, HDDS-250.001.patch
>
>
> The following functions in ContainerData are redundant. MetadataPath and
> ChunksPath are specific to KeyValueContainerData.
> ContainerPath is the common path in ContainerData which points to the base
> dir of the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
