[
https://issues.apache.org/jira/browse/HDDS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548296#comment-16548296
]
Hanisha Koneru commented on HDDS-250:
-------------------------------------
Thanks for the review [~ljain].
I agree that we should have {{numPendingDeletionBlocks}} and
{{deleteTransactionId}} in KeyValueContainerData rather than in ContainerData.
But that will be a fairly big refactoring by itself. The whole
{{BlockDeletingService}} would have to be refactored as it depends heavily on
ContainerData.numPendingDeletionBlocks.
I think it would be better if we do that refactoring in a separate Jira along
with the ContainerReport refactoring. What do you think?
> Cleanup ContainerData
> ---------------------
>
> Key: HDDS-250
> URL: https://issues.apache.org/jira/browse/HDDS-250
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-250.000.patch, HDDS-250.001.patch,
> HDDS-250.002.patch, HDDS-250.003.patch
>
>
> The following functions in ContainerData are redundant. MetadataPath and
> ChunksPath are specific to KeyValueContainerData.
> ContainerPath is the common path in ContainerData which points to the base
> dir of the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
