[
https://issues.apache.org/jira/browse/HDDS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548204#comment-16548204
]
Mukul Kumar Singh commented on HDDS-179:
----------------------------------------
Thanks for working on this [~shashikant]. Please find my comments as following
1) There are some findbugs issues with the patch, can you please fix these
issues ?
2) ContainerStateMachine.java:23, there is a unrelated/unused import, please
remove this import.
3) ContainerStateMachine.java:207, this can be replaced with computeIfAbsent
4) RatisHelper.java:136-165, getContainerIdForWriteTypeCmd can be replaced with
HddsUtils#getContainerID and HddsUtils#isReadOnly
5) Also lets correct the javadoc at ContainerStateMachine.java:68, this should
be changed to HddsUtils#isReadOnly
6) TestContainerStateMachine:43, there are wildcards in import
> CloseContainer command should be executed only if all the prior "Write" type
> container requests get executed
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDDS-179
> URL: https://issues.apache.org/jira/browse/HDDS-179
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client, Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-179.01.patch, HDDS-179.02.patch
>
>
> When a close Container command request comes to a Datanode (via SCM hearbeat
> response) through the Ratis protocol, all the prior enqueued "Write" type of
> request like putKey, WriteChunk, DeleteKey, CompactChunk etc should be
> executed first before CloseContainer request gets executed. This
> synchronization needs to be handled in the containerStateMachine. This Jira
> aims to address this.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
