[
https://issues.apache.org/jira/browse/HDDS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554454#comment-16554454
]
Mukul Kumar Singh commented on HDDS-179:
----------------------------------------
Thanks for the update patch [~shashikant]. The updated patch looks pretty good
to me.
Couple of comments,
a) I feel the code in ContainerStateMachine can be simplified with a helper
class to manager the Container ops, this will simplify both the manageability
and the usage.
b) XceiverClientRatis#isReadonly can be replaced with HddsUtils#isReadonly
> CloseContainer command should be executed only if all the prior "Write" type
> container requests get executed
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDDS-179
> URL: https://issues.apache.org/jira/browse/HDDS-179
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client, Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-179.01.patch, HDDS-179.02.patch, HDDS-179.03.patch,
> HDDS-179.04.patch
>
>
> When a close Container command request comes to a Datanode (via SCM hearbeat
> response) through the Ratis protocol, all the prior enqueued "Write" type of
> request like putKey, WriteChunk, DeleteKey, CompactChunk etc should be
> executed first before CloseContainer request gets executed. This
> synchronization needs to be handled in the containerStateMachine. This Jira
> aims to address this.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
