[
https://issues.apache.org/jira/browse/HDDS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559283#comment-16559283
]
Lokesh Jain edited comment on HDDS-245 at 7/27/18 5:41 AM:
-----------------------------------------------------------
Thanks [~elek] for working on this! The patch looks very good to me. I have a
few minor comments.
# ReportResult:58,59 - we can keep the missingContainers and newContainers as
null.
# ContainerMapping#getContainerWithPipeline needs to be updated for closed
container case. For closed containers we need to fetch the datanodes from
ContainerStateMap and return the appropriate pipeline information.
# START_REPLICATION is currently not fired by any publisher. I guess it will
be part of another jira?
# We are currently processing the report as soon it is received. Are we
handling the case when a container is added in one DN and has been removed from
another DN? In such a case we might be sending out a false replicate event as
replication count would still match the replication factor.
was (Author: ljain):
Thanks [~elek] for working on this! I have a few minor comments.
# ReportResult:58,59 - we can keep the missingContainers and newContainers as
null.
# ContainerMapping#getContainerWithPipeline needs to be updated for closed
container case. For closed containers we need to fetch the datanodes from
ContainerStateMap and return the appropriate pipeline information.
# START_REPLICATION is currently not fired by any publisher. I guess it will
be part of another jira?
# We are currently processing the report as soon it is received. Are we
handling the case when a container is added in one DN and has been removed from
another DN? In such a case we might be sending out a false replicate event as
replication count would still match the replication factor.
> Handle ContainerReports in the SCM
> ----------------------------------
>
> Key: HDDS-245
> URL: https://issues.apache.org/jira/browse/HDDS-245
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-245.001.patch, HDDS-245.002.patch,
> HDDS-245.003.patch
>
>
> HDDS-242 provides a new class ContainerReportHandler which could handle the
> ContainerReports from the SCMHeartbeatDispatchere.
> HDDS-228 introduces a new map to store the container -> datanode[] mapping
> HDDS-199 implements the ReplicationManager which could send commands to the
> datanodes to copy the datanode.
> To wire all these components, we need to put implementation to the
> ContainerReportHandler (created in HDDS-242).
> The ContainerReportHandler should process the new ContainerReportForDatanode
> events, update the containerStateMap and node2ContainerMap and calculate the
> missing/duplicate containers and send the ReplicateCommand to the
> ReplicateManager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
