[
https://issues.apache.org/jira/browse/HDFS-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572120#comment-16572120
]
genericqa commented on HDFS-13777:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 38 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-12090 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
19s{color} | {color:green} HDFS-12090 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m
28s{color} | {color:green} HDFS-12090 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} HDFS-12090 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
29s{color} | {color:green} HDFS-12090 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 15s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
27s{color} | {color:green} HDFS-12090 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
24s{color} | {color:green} HDFS-12090 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 27m
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 27m 27s{color}
| {color:red} root generated 204 new + 1269 unchanged - 199 fixed = 1473 total
(was 1468) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
23s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
25s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 47s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
44s{color} | {color:red} hadoop-common-project/hadoop-common generated 2 new +
0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
53s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs-client generated 2 new
+ 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
8s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 13 new + 0
unchanged - 0 fixed = 13 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
33s{color} | {color:red} hadoop-hdfs-project_hadoop-hdfs-client generated 1 new
+ 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
55s{color} | {color:red} hadoop-hdfs-project_hadoop-hdfs generated 1 new + 1
unchanged - 0 fixed = 2 total (was 1) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 54s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
41s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 19s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m
9s{color} | {color:green} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
37s{color} | {color:green} hadoop-fs2img in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
42s{color} | {color:red} The patch generated 14 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}280m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Class org.apache.hadoop.fs.BBPartHandle defines non-transient
non-serializable instance field bytes In BBPartHandle.java:instance field
bytes In BBPartHandle.java |
| | Class org.apache.hadoop.fs.BBUploadHandle defines non-transient
non-serializable instance field bytes In BBUploadHandle.java:instance field
bytes In BBUploadHandle.java |
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs-client |
| | Dead store to lfs in
org.apache.hadoop.hdfs.DistributedFileSystem.createSync(String, String, String)
At
DistributedFileSystem.java:org.apache.hadoop.hdfs.DistributedFileSystem.createSync(String,
String, String) At DistributedFileSystem.java:[line 3304] |
| | Null passed for non-null parameter of
org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType)
in
org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry)
Method invoked at PBHelperClient.java:of
org.apache.hadoop.hdfs.protocol.proto.HdfsProtos$SnapshotDiffReportListingEntryProto$Builder.setFileType(HdfsProtos$HdfsFileStatusProto$FileType)
in
org.apache.hadoop.hdfs.protocolPB.PBHelperClient.convert(SnapshotDiffReportListing$DiffReportListingEntry)
Method invoked at PBHelperClient.java:[line 2730] |
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.lambda$getBackingUpFromSnapshotName$3(XAttr):in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.lambda$getBackingUpFromSnapshotName$3(XAttr):
new String(byte[]) At MountManager.java:[line 372] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.performInitialDiff(Path,
String):in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.performInitialDiff(Path,
String): String.getBytes() At MountManager.java:[line 272] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.setXattrForBackupMount(SyncMount):in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.setXattrForBackupMount(SyncMount):
String.getBytes() At MountManager.java:[line 174] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.storeBackingUpFromSnapshotNameAsXAttr(Path,
String, XAttrSetFlag):in
org.apache.hadoop.hdfs.server.namenode.syncservice.MountManager.storeBackingUpFromSnapshotNameAsXAttr(Path,
String, XAttrSetFlag): String.getBytes() At MountManager.java:[line 321] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.SyncMonitor.getSourceSnapshotId(SnapshotDiffReport):in
org.apache.hadoop.hdfs.server.namenode.syncservice.SyncMonitor.getSourceSnapshotId(SnapshotDiffReport):
String.getBytes() At SyncMonitor.java:[line 249] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.SyncMonitor.getTargetSnapshotId(SnapshotDiffReport):in
org.apache.hadoop.hdfs.server.namenode.syncservice.SyncMonitor.getTargetSnapshotId(SnapshotDiffReport):
String.getBytes() At SyncMonitor.java:[line 261] |
| | Inconsistent synchronization of
org.apache.hadoop.hdfs.server.namenode.syncservice.SyncServiceSatisfier.syncServiceSatisfierThread;
locked 70% of time Unsynchronized access at SyncServiceSatisfier.java:70% of
time Unsynchronized access at SyncServiceSatisfier.java:[line 161] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.DirectoryPlanner.convertPathToAbsoluteFile(byte[],
Path):in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.DirectoryPlanner.convertPathToAbsoluteFile(byte[],
Path): new String(byte[]) At DirectoryPlanner.java:[line 58] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.DirectoryPlanner.convertPathToAbsoluteFile(byte[],
Path, String):in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.DirectoryPlanner.convertPathToAbsoluteFile(byte[],
Path, String): new String(byte[]) At DirectoryPlanner.java:[line 68] |
| | Using .equals to compare two byte[]'s, (equivalent to ==) in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.PartitionedDiffReport.translateToTargetName(SnapshotDiffReport$DiffReportEntry,
List) At PartitionedDiffReport.java:byte[]'s, (equivalent to ==) in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.PartitionedDiffReport.translateToTargetName(SnapshotDiffReport$DiffReportEntry,
List) At PartitionedDiffReport.java:[line 234] |
| | Using .equals to compare two byte[]'s, (equivalent to ==) in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.PartitionedDiffReport.translateToTemporaryName(SnapshotDiffReport$DiffReportEntry,
List) At PartitionedDiffReport.java:byte[]'s, (equivalent to ==) in
org.apache.hadoop.hdfs.server.namenode.syncservice.planner.PartitionedDiffReport.translateToTemporaryName(SnapshotDiffReport$DiffReportEntry,
List) At PartitionedDiffReport.java:[line 197] |
| | Dead store to multipartCompleteMetadataSyncTask in
org.apache.hadoop.hdfs.server.namenode.syncservice.updatetracker.multipart.CompleteTracker.markFinished(UUID,
Runnable) At
CompleteTracker.java:org.apache.hadoop.hdfs.server.namenode.syncservice.updatetracker.multipart.CompleteTracker.markFinished(UUID,
Runnable) At CompleteTracker.java:[line 40] |
| | Unread public/protected field:At MetadataSyncTask.java:[line 96] |
| Failed junit tests | hadoop.fs.TestLocalFileSystemMultipartUploader |
| | hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages |
| | hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger |
| | hadoop.hdfs.server.datanode.TestDataNodeReconfiguration |
| | hadoop.hdfs.web.TestWebHdfsTimeouts |
| | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
| | hadoop.hdfs.TestDFSInotifyEventInputStream |
| | hadoop.fs.TestHDFSMultipartUploader |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| | hadoop.hdfs.server.blockmanagement.TestDatanodeManager |
| | hadoop.hdfs.server.datanode.TestGrandSyncTask |
| | hadoop.hdfs.server.namenode.TestNNThroughputBenchmark |
| | hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDFS-13777 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12934645/HDFS-13777-HDFS-12090.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle xml cc shellcheck shelldocs |
| uname | Linux 9800b390d9e2 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14
08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-12090 / bcd1aaa |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| shellcheck | v0.4.6 |
| findbugs | v3.1.0-RC1 |
| javac |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/diff-compile-javac-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 3142 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs
hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-tools/hadoop-fs2img U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/24717/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> [PROVIDED Phase 2] Scheduler in the NN for distributing DNA_BACKUP work.
> ------------------------------------------------------------------------
>
> Key: HDFS-13777
> URL: https://issues.apache.org/jira/browse/HDFS-13777
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ewan Higgs
> Assignee: Ewan Higgs
> Priority: Major
> Attachments: HDFS-13777-HDFS-12090.001.patch,
> HDFS-13777-HDFS-12090.002.patch
>
>
> When the SyncService is running, it should periodically take snapshots, make
> a snapshotdiff, and then distribute DNA_BACKUP work to the Datanodes (See
> HDFS-13421). Upon completion of the work, the NN should update the AliasMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
