[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572447#comment-16572447
]
Hanisha Koneru commented on HDDS-328:
-------------------------------------
Thanks [~elek] for working on this improvement.
A few comments:
* Do we allow copying open containers? I am thinking not. We should add a
check for that the container is closed before packing it.
* When creating a container object and choosing the volume for it, we need to
specify the max container size. The max size is a configurable parameter. The
dest node might have a different max size setting from the source container.
For example, lets say the container to be copied has 5GB max size and is full.
We want to copy it into a node with max size set to 2GB and as such we choose a
volume with 2.5GB space left. When actually copying the container data, we
would get disk out of space exception as we are trying to copy 5GB whereas we
have only 2.5GB space on disk.
To avoid this, we should first copy and extract the container tar into the new
node and then update the path variables.
* Is there any reason for making the container file in tarball a hidden file?
* Can we change the *_METADATADB_DIR_NAME to indicate that it is the db file.
Currently, we have both .container file and .db file under the metadata
directory. So it might get confusing on what "metadata” denotes.
* We should acquire the container write lock before unpacking and updating in
KeyValueContainer#importContainerData.
* Once the container has been successfully copied, we should update its other
metrics such as keyCount
> Support export and import of the KeyValueContainer
> --------------------------------------------------
>
> Key: HDDS-328
> URL: https://issues.apache.org/jira/browse/HDDS-328
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-328.002.patch
>
>
> In HDDS-75 we pack the container data to an archive file, copy to other
> datanodes and create the container from the archive.
> As I wrote in the comment of HDDS-75 I propose to separate the patch to make
> it easier to review.
> In this patch we need to extend the existing Container interface with adding
> export/import methods to save the container data to one binary input/output
> stream.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
