[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581281#comment-16581281
]
Xiaoyu Yao commented on HDDS-328:
---------------------------------
Thanks [~elek] for working on this. The patch v3 looks excellent to me overall.
I just have few comments in addition to [~hanishakoneru]'s comment above.
KeyValueContainer.java
Line 387-388: these should be removed as it is a dup of line 383-385.
Line 398: agree with Hanisha that we need to handle the error case. I'm OK if
you plan to add that in HDDS-75.
TarContainerPacker.java
Have we consider adding other compressor support such as bzip or lz4 which has
native codec optimization in existing hadoop code?
Line 81/91: we should avoid using hard-coded path separators the applies only
to *nix OS.
Line 123: should we check if the tarInput.read return -1 (EOF) to avoid adding
remaining negatively?
Line 164-165: can we use try-with-resource to avoid leak in the exception case?
> Support export and import of the KeyValueContainer
> --------------------------------------------------
>
> Key: HDDS-328
> URL: https://issues.apache.org/jira/browse/HDDS-328
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-328.002.patch, HDDS-328.003.patch
>
>
> In HDDS-75 we pack the container data to an archive file, copy to other
> datanodes and create the container from the archive.
> As I wrote in the comment of HDDS-75 I propose to separate the patch to make
> it easier to review.
> In this patch we need to extend the existing Container interface with adding
> export/import methods to save the container data to one binary input/output
> stream.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
