[
https://issues.apache.org/jira/browse/HDDS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573289#comment-16573289
]
Elek, Marton commented on HDDS-325:
-----------------------------------
Thank you very much to work on this [~ljain].
This patch is quite huge. I am not sure if I understood all of the details,
some of my comments could be originated by a partial understanding. I started
with the EventHandler part as I am more familiar with it.
1. Until now there were a clear separation: the events had all of the data and
the EventHandlers had all of the logic. With this patch it will be changed as
{{RetriablePayload}} contains onFinished/onTimeout method. I can’t see the real
reason behind this change, because all of the retry logic could be handled by a
very simple {{RetriableEventWatcher}} which has one line in the onTimout method.
2. EventWatcher is also modified to support multiple trigger/completion event.
I am not against this patch but I can’t see any use case for this in this patch
(I may miss something). As I see the watchEvents has never been used. (which
would add more than one completion and trigger event). Unless we have real need
for it, I would prefer to keep it as simple as possible.
3. As I see currently the block deletion is handled by a
SCMEvents.RETRIABLE_DATANODE_COMMAND but (for example) the
ReplicateContainerCommand (from ReplicationManager) is retried with a different
approach. I am not against creating a generic solution for retrying but IMHO we
should use the same approach for all of the CommandForDatanodeEvents.
4. I like the change to enable multiple command status in the same HB. Seems to
be reasonable.
> Add event watcher for delete blocks command
> -------------------------------------------
>
> Key: HDDS-325
> URL: https://issues.apache.org/jira/browse/HDDS-325
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode, SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-325.001.patch, HDDS-325.002.patch
>
>
> This Jira aims to add watcher for deleteBlocks command. It removes the
> current rpc call required for datanode to send the acknowledgement for
> deleteBlocks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
