[
https://issues.apache.org/jira/browse/HDDS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573588#comment-16573588
]
Lokesh Jain commented on HDDS-325:
----------------------------------
[~elek] Thanks for reviewing the patch! I will try to make the changes more
clear below.
# I wanted to have a single RetriableEventWatcher which watches over all the
events which need to be retried. That is the reason I introduced watchEvents
function in the EventWatcher class. I thought we could use this event watcher
to watch over CloseContainer as well as ReplicationEvent.
# The reason I have added onFinished/onTimeout api in RetriablePayload so as
to support different events in a single event watcher. Different payloads can
trigger events according to their requirement and can still use the same
watcher.
# For replication command we can pass the request as part of the payload. Then
payload can fire the required event in its onTimeout function.
The patch helps in getting a single watcher to watch over all the events. Using
this approach we will not need to fire separate events for tracking the
DATANODE_COMMAND. We can easily add RETRIABLE_DATANODE_COMMAND into the watcher
and it can watch over all these events. I was also thinking of adding the
timeout duration as part of the RetriablePayload api so that we can have
different timeout for each event type.
> Add event watcher for delete blocks command
> -------------------------------------------
>
> Key: HDDS-325
> URL: https://issues.apache.org/jira/browse/HDDS-325
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode, SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-325.001.patch, HDDS-325.002.patch
>
>
> This Jira aims to add watcher for deleteBlocks command. It removes the
> current rpc call required for datanode to send the acknowledgement for
> deleteBlocks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
