[ 
https://issues.apache.org/jira/browse/HDFS-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576963#comment-16576963
 ] 

Daniel Templeton commented on HDFS-13746:
-----------------------------------------

Thanks for the update.  More comments:

* I should have caught this the first time around: what's up with the 
{{gN.toArray(str_groups)}} calls?  {{str_groups}} is only used for printing.  
Why not call {{gN.toString()}} instead?
* The max trials calculation might be simpler if you keep it as a long.  No 
real need to convert to an int the way you're using it.
* Is it useful to set the log level to DEBUG in the setup?  It prevents the 
user from controlling the log level declaratively.

> Still occasional "Should be different group" failure in 
> TestRefreshUserMappings#testGroupMappingRefresh
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13746
>                 URL: https://issues.apache.org/jira/browse/HDFS-13746
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>         Attachments: HDFS-13746.001.patch, HDFS-13746.002.patch, 
> HDFS-13746.003.patch
>
>
> In https://issues.apache.org/jira/browse/HDFS-13723, increasing the amount of 
> time in sleep() helps but the problem still appears, which is annoying.
>  
> Solution:
> Use a loop to allow the test case to fail maxTrials times before declaring 
> failure. Wait 50 ms between each retry.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to