[
https://issues.apache.org/jira/browse/HDDS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586537#comment-16586537
]
Xiaoyu Yao commented on HDDS-356:
---------------------------------
Thanks [~anu] for working on this. The patch looks excellent for me. I only
have few minor comments below.
RDBStore.java
Line 62: should we hide the RocksDB.DEFAULT_COLUMN_FAMILY from the client of
this class so that the client only needs to pass the customized column families
or use DBOptions#setCreateMissingColumnFamilies(true); like we did in
RDBStoreTest setup?
This way, we only need to add those customized table names and configurations.
I assume these will be persisted externally, maybe in a later patch when
integrate with OM?
Line 77: Can we wrap the column family options as part of RDBTable class? This
allows do per column family customization later? We will need to revisit when
working on the RockDB tuning per table(column family), can you add a comment
here?
Line 222: is this only available for rocksDB? Can we get the estimate per
column family(table)?
RDBStoreTest.java
Line 75-77: this can be removed as the RDBStore#close will close the DBOptions
as well.
Line 129: can we add a assert that
{code}
firstTable.get(key); //should not return the moved key/value?
{code}
Table.java
Line 59: can you clarify the expected return value when the key is not found,
do we expect a null or an exception?
Line 148/159: can we provide a method that provide key/value without deep copy?
RDBTableStoreTest.java
NIT: as a tradition, this should be named TestRDBTableStore, similar applies to
RDBStoreTest.
Line 71-73: this can be removed as the RDBStore#close will close the DBOptions
as well.
Line 148: batch needs to be closed or wrapped with try-with-resource
> Support ColumnFamily based RockDBStore and TableStore
> -----------------------------------------------------
>
> Key: HDDS-356
> URL: https://issues.apache.org/jira/browse/HDDS-356
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-356.001.patch
>
>
> This is to minimize the performance impacts of the expensive RocksDB table
> scan problems from background services disabled by HDDS-355.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
